Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player_avplay] Fix not display video issue when start play #644

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

hyue7
Copy link
Collaborator

@hyue7 hyue7 commented Dec 22, 2023

Issue: there is no video and audio after start play.

  1. player should call SetDisplayVisible to display one fram after prepare is done.
  2. plusplayer don't need to set playback speed when start play, otherwise it will clear buffer and restart buffer.
  3. plusplayer can set playback speed when player is pause. Remove code:
if (!value.isPlaying) {
       return;
    }

@hyue7 hyue7 requested a review from JSUYA December 22, 2023 12:33
Copy link
Contributor

@xiaowei-guan xiaowei-guan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaowei-guan xiaowei-guan merged commit 0d363f0 into flutter-tizen:master Dec 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants